Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug Footer #1814

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix Bug Footer #1814

merged 1 commit into from
Feb 12, 2025

Conversation

LuizFNJ
Copy link
Collaborator

@LuizFNJ LuizFNJ commented Feb 11, 2025

Description

I made a mistake by not testing on scrollable pages and only tested on pages without scroll, not realizing that the footer was breaking. Essentially, it broke the layout on scrollable pages because the footer wasn't following the page's flow correctly.

To fix this, I removed the position: absolute from the footer and used alignSelf: "flex-end" to ensure that it always stays at the bottom of the layout. In the parent component, I added display: "grid" and minHeight: "100vh" to ensure that the structure occupies the full height of the screen.

Additionally, I wrapped the other components inside a Box, making sure they are treated as a single unit within the grid. This way, the elements stay grouped correctly without being stretched unexpectedly.

fixes #1809

before:
Screenshot from 2025-02-11 22-39-34
Screenshot from 2025-02-11 22-39-21
after:
Screenshot from 2025-02-11 23-04-38
Screenshot from 2025-02-11 22-39-41
I am testing on other pages too
Screenshot from 2025-02-11 22-39-53
Screenshot from 2025-02-11 23-05-14

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Basically, test both scrollable and non-scrollable pages

@thesocialdev thesocialdev merged commit 77579f1 into stage Feb 12, 2025
6 of 7 checks passed
@thesocialdev thesocialdev deleted the Fix-bug-footer branch February 12, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

Bug: Broken footer layout on login page
2 participants